| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Date: | 2020-01-09 16:10:10 |
| Message-ID: | 72457f7b-4eed-c238-9e21-c113f793cf36@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2020-01-09 16:50, Tom Lane wrote:
> Christoph Berg <myon(at)debian(dot)org> writes:
>> Fwiw if libedit in xenial is Just Broken and fixing the tests would
>> just codify the brokenness without adding any value, I'll just disable
>> that test in that particular build. It looks like setting
>> with_readline=no on the make command line should work.
>
> That would disable psql's tab completion, command editing, and history
> altogether, which I doubt is what you want for production builds.
> If we conclude we can't work around the testing issues for ancient
> libedit, probably the right answer is to provide a switch to
> disable just the test. I've been trying to dance around that
> conclusion, but maybe we should just do it and move on.
I think he means something like
make check with_readline=no
not for the actual build.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-01-09 16:13:38 | pgsql: Add pg_shmem_allocations view. |
| Previous Message | Tom Lane | 2020-01-09 15:50:11 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-01-09 16:13:46 | Re: [HACKERS] pg_shmem_allocations view |
| Previous Message | Tom Lane | 2020-01-09 16:06:37 | Re: Recognizing superuser in pg_hba.conf |