Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.
Date: 2016-10-04 15:29:51
Message-ID: 7244.1475594991@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Apparently, 'make world' does not build worker_spi. I thought 'make
> world' was supposed to build everything?

You'd have thunk, yeah. It looks like the issue is that src/Makefile
is selective about recursing into certain subdirectories of test/,
but mostly not test/ itself. src/test/Makefile naively believes it's
in charge, though. Probably that logic ought to get shoved down one
level, and then adjusted so that src/test/modules gets built by "all".
Or else teach top-level "make world" to do "make all" in src/test/,
but that seems like it's just doubling down on confusing interconnections.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-10-04 15:51:15 pgsql: Remove trailing commas from enums.
Previous Message Robert Haas 2016-10-04 15:20:18 Re: pgsql: Extend framework from commit 53be0b1ad to report latch waits.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-10-04 15:45:51 Re: Misidentification of Python shared library
Previous Message Pavel Stehule 2016-10-04 15:29:46 Re: proposal: psql \setfileref