Re: contrib modules and relkind check

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: contrib modules and relkind check
Date: 2017-03-09 03:02:10
Message-ID: 72116b2a-ba49-06bf-00eb-07bf7a06a008@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/03/09 11:51, Michael Paquier wrote:
> On Wed, Mar 8, 2017 at 5:10 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> On 2017/03/08 16:47, Michael Paquier wrote:
>>> Only regular tables are tested as valid objects. Testing toast tables
>>> is not worth the complication. Could you add as well a matview?
>>
>> Done in the attached updated patch.
>
> +select count(*) > 0 from pg_visibility('matview');
> + ?column?
> +----------
> + f
> +(1 row)
> That's quite a generic name :) You may want to use less common names
> in your tests.

I agree. Updated patch attached.

>
> OK, I am marking that as ready for committer.

Thanks.

Regards,
Amit

Attachment Content-Type Size
0001-Add-relkind-checks-to-certain-contrib-modules.patch text/x-diff 20.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-03-09 03:10:49 Re: Gather Merge
Previous Message Michael Paquier 2017-03-09 02:51:25 Re: contrib modules and relkind check