Re: [PATCH] Connection time for \conninfo

From: David Steele <david(at)pgmasters(dot)net>
To: Rodrigo Ramírez Norambuena <decipher(dot)hk(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Connection time for \conninfo
Date: 2020-03-10 16:50:48
Message-ID: 71e65489-2ea1-ae21-0189-fdd52864ccc2@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Rodrigo,

On 2/27/20 4:21 AM, Peter Eisentraut wrote:
> My opinion is that this is not particularly useful and not appropriate
> to piggy-back onto \conninfo.  Connection information including host,
> port, database, user name is a well-established concept in PostgreSQL
> programs and tools and it contains a delimited set of information.
> Knowing what server and what database you are connected to also seems
> kind of important.  Moreover, this is information that is under control
> of the client, so it must be tracked on the client side.
>
> Knowing how long you've been connected on the other hand seems kind of
> fundamentally unimportant.  If we add that, what's to stop us from
> adding other statistics of minor interest such as how many commands
> you've run, how many errors there were, etc.  The connection time is
> already available, and perhaps we should indeed make it a bit easier to
> get, but it doesn't need to be a psql command.

The consensus from the committers (with the exception of Álvaro) seems
to be that this is not a feature we want. FWIW, I agree with the majority.

I'll mark this as rejected on MAR-16 unless Álvaro makes an argument for
committing it.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kuntal Ghosh 2020-03-10 17:05:05 Re: backend type in log_line_prefix?
Previous Message Julien Rouhaud 2020-03-10 16:38:30 Re: backend type in log_line_prefix?