Re: psql SET/RESET/SHOW tab completion

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql SET/RESET/SHOW tab completion
Date: 2005-08-13 15:39:59
Message-ID: 7092.1123947599@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I am wondering if is worth managing which items should be displayed or
> not, and if we should just give up and display them all. The GUC system
> is just too dynamic.

Not sure. I count 98 GUC variables currently listed in tab-complete.c,
and 162 rows in pg_settings. So listing them all would be a pretty
sizable increase (65%) in what's already an unwieldy list. I would
prefer to see some thought given to removing useless entries ... eg,
I doubt anyone needs tab completion for "trace_notify" or "wal_debug".

However, if you favor a "no thought required" approach, listing 'em
all is certainly the path of least resistance. I'm just dubious that
that maximizes the usefulness of tab completion.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-08-13 15:41:17 Re: psql SET/RESET/SHOW tab completion
Previous Message Brendan Jurd 2005-08-13 15:35:51 Dollar-quoted strings