Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup
Date: 2018-12-31 09:50:20
Message-ID: 6fcc7151-3d0e-8d88-efaf-dca5b35214e3@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 31/12/2018 09:07, Michael Paquier wrote:
> On Sun, Dec 30, 2018 at 02:50:46PM +0900, Michael Paquier wrote:
>> A personal note on the matter: I tend to prefer using the passive form
>> in such log messages because they are impersonal, and not use the
>> direct form because it becomes more personally addressed to the user.
>> I may be living abroad for too long though ;)
>
> So, are there any objections regarding the previously-sent patch or
> other suggestions? All comments from Peter and Alvaro have been
> included.

I like this version of the patch.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message denty 2018-12-31 10:41:15 Re: Implementing Incremental View Maintenance
Previous Message David Rowley 2018-12-31 09:38:18 Re: pg_dump multi VALUES INSERT