| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Log LDAP "diagnostic messages"? |
| Date: | 2017-10-13 02:59:27 |
| Message-ID: | 6e4552f6-14fe-e21f-17fb-560b263c9708@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/24/17 07:00, Thomas Munro wrote:
> Fair point. In that case there are a few others we should consider
> moving down too for consistency, like in the attached.
> Thanks, that is much tidier. Done that way in the attached.
>
> Here also is a small addition to your TAP test which exercises the
> non-NULL code path because slapd rejects TLS by default with a
> diagnostic message. I'm not sure if this is worth adding, since it
> doesn't actually verify that the code path is reached (though you can
> see that it is from the logs).
Committed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-10-13 03:00:02 | Re: oversight in EphemeralNamedRelation support |
| Previous Message | Tom Lane | 2017-10-13 02:44:20 | Re: pgsql: Improve performance of SendRowDescriptionMessage. |