Re: pgsql: Improve performance of SendRowDescriptionMessage.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
Date: 2017-10-13 02:44:20
Message-ID: 12267.1507862660@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote:
>> Noah, any chance you could force restrict to off on that animal?

> I can confirm it allows "make check" to pass.

So that leaves us with two theories:

1. hornet's compiler contains a bug that causes it to misoptimize
in the presence of "restrict".

2. There's a bug in the way HEAD is applying "restrict", which happens
not to manifest on other platforms.

While I have to agree with Andres' evident feeling that it's probably
#1, I do not think we should dismiss #2 without inquiring a bit
harder. It would be really useful, I think, if we could characterize
exactly how the RowDescription output is broken in that build.
Noah, could you capture some of those messages somehow?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-10-13 02:55:07 pgsql: Log diagnostic messages if errors occur during LDAP auth.
Previous Message Noah Misch 2017-10-13 02:39:04 Re: pgsql: Improve performance of SendRowDescriptionMessage.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-10-13 02:59:27 Re: Log LDAP "diagnostic messages"?
Previous Message Noah Misch 2017-10-13 02:39:04 Re: pgsql: Improve performance of SendRowDescriptionMessage.