Re: Allow auto_explain to log plans before queries are executed

From: David Steele <david(at)pgmasters(dot)net>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allow auto_explain to log plans before queries are executed
Date: 2020-04-08 13:25:26
Message-ID: 6de4356c-f18e-7c87-49bc-0bfa4b57a067@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/5/20 8:46 AM, Julien Rouhaud wrote:
> On Thu, Feb 27, 2020 at 7:31 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>>
>> On Thu, Feb 27, 2020 at 7:12 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>>
>>> čt 27. 2. 2020 v 7:01 odesílatel Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> napsal:
>>>> I think "query debugger" feature you proposed is out of scope of
>>>> auto_explain module. I also think the feature to analyze running
>>>> query online is great, but we will need another discussion on a new
>>>> module or eature for it.
>>>
>>>
>>> sure. My note was about using auto_explain like query_debugger. It has not too sense, and from this perspective, the original proposal to log plan before execution has more sense.
>>>
>>> you can log every plan with higher cost than some constant.
>>
>> Yes I thought about that too. If you're not in an OLAP environment
>> (or with a specific user running few expensive queries), setup an
>> auto_explain.log_before_execution_min_cost.
>
> There was some discussion but no clear consensus on what should really
> be done. I'm marking the patch as waiting on author which seems more
> accurate. Feel free to switch it back if that's a wrong move.

There does seem to be any progress towards a consensus so I'm marking
this Returned with Feedback.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jehan-Guillaume de Rorthais 2020-04-08 13:26:03 Re: [BUG] non archived WAL removed during production crash recovery
Previous Message Robert Haas 2020-04-08 13:24:13 Re: Improving connection scalability: GetSnapshotData()