Re: Crash issue in PG18.5 regression

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, "Masashi Kamura (Fujitsu)" <kamura(dot)masashi(at)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Crash issue in PG18.5 regression
Date: 2026-08-15 21:53:39
Message-ID: 6c479549b51b738da3065fd979af8bd1ea80b654.camel@j-davis.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2026-08-13 at 22:17 -0700, Jeff Davis wrote:
> On Tue, 2026-08-11 at 14:31 -0400, Andres Freund wrote:
> > Hm. If I infer the pg_strlower() API correctly - it's utterly
> > underdocumented
>
> Agreed. Patch attached.
>
> > I'd also make i size_t, given that the input is size_t.  Perhaps
> > practically
> > no problem, but I see no reason to not use size_t here.
>
> Patch attached for that, too.
>
> I also attached patches to make all the functions work with
> collate_is_c, and fixed up the -1 API in 18.

Now with a C test module (made with AI assistance).

I plan to start committing these fairly soon. I'm not sure whether to
backport the C test module, but I included the patches to do so.

Regards,
Jeff Davis

Attachment Content-Type Size
vPG18-0001-Fixup-5f003855e7-for-srclen-0.patch text/x-patch 1.9 KB
vPG18-0002-pg_locale.c-unicode_case.c-use-size_t-for-iter.patch text/x-patch 2.3 KB
vPG18-0003-Add-missing-comments-in-pg_locale.c.patch text/x-patch 6.4 KB
vPG18-0004-Ensure-all-pg_locale.h-APIs-work-with-collate_.patch text/x-patch 4.0 KB
vPG18-0005-Add-C-test-module-for-pg_locale.h-APIs.patch text/x-patch 14.3 KB
vPG19-0001-pg_locale.c-unicode_case.c-use-size_t-for-iter.patch text/x-patch 2.3 KB
vPG19-0002-Add-missing-comments-in-pg_locale.c.patch text/x-patch 5.9 KB
vPG19-0003-Ensure-all-pg_locale.h-APIs-work-with-collate_.patch text/x-patch 3.8 KB
vPG19-0004-Add-C-test-module-for-pg_locale.h-APIs.patch text/x-patch 13.6 KB
vPG20-0001-Add-missing-comments-in-pg_locale.c.patch text/x-patch 5.9 KB
vPG20-0002-Ensure-all-pg_locale.h-APIs-work-with-collate_.patch text/x-patch 3.8 KB
vPG20-0003-Add-C-test-module-for-pg_locale.h-APIs.patch text/x-patch 13.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2026-08-15 22:06:25 gistkillitems can LP_DEAD-mark the wrong tuples on a rescan
Previous Message Daniel Gustafsson 2026-08-15 20:45:01 Re: basebackup: do not verify checksums on pages written before enabling checksums