| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, "Masashi Kamura (Fujitsu)" <kamura(dot)masashi(at)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Crash issue in PG18.5 regression |
| Date: | 2026-08-14 05:17:40 |
| Message-ID: | 3d2bf8bebb21ded729431fa25c92d2425fa615f5.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2026-08-11 at 14:31 -0400, Andres Freund wrote:
> Hm. If I infer the pg_strlower() API correctly - it's utterly
> underdocumented
Agreed. Patch attached.
> I'd also make i size_t, given that the input is size_t. Perhaps
> practically
> no problem, but I see no reason to not use size_t here.
Patch attached for that, too.
I also attached patches to make all the functions work with
collate_is_c, and fixed up the -1 API in 18.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| vPG18-0001-Fixup-5f003855e7-for-srclen-0.patch | text/x-patch | 1.9 KB |
| vPG18-0002-pg_locale.c-unicode_case.c-use-size_t-for-iter.patch | text/x-patch | 2.3 KB |
| vPG18-0003-Add-missing-comments-in-pg_locale.c.patch | text/x-patch | 6.4 KB |
| vPG18-0004-Ensure-all-pg_locale.h-APIs-work-with-collate_.patch | text/x-patch | 4.0 KB |
| vPG19-0001-pg_locale.c-unicode_case.c-use-size_t-for-iter.patch | text/x-patch | 2.3 KB |
| vPG19-0002-Add-missing-comments-in-pg_locale.c.patch | text/x-patch | 5.9 KB |
| vPG19-0003-Ensure-all-pg_locale.h-APIs-work-with-collate_.patch | text/x-patch | 3.8 KB |
| vPG20-0001-Add-missing-comments-in-pg_locale.c.patch | text/x-patch | 5.9 KB |
| vPG20-0002-Ensure-all-pg_locale.h-APIs-work-with-collate_.patch | text/x-patch | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Denis Smirnov | 2026-08-14 05:19:58 | Re: Redundant qualifier elimination |
| Previous Message | Bertrand Drouvot | 2026-08-14 04:40:56 | Re: Introduce XID age based replication slot invalidation |