Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

From: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
To: Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Date: 2025-07-10 22:40:43
Message-ID: 6CD16A54-BFEE-4CB5-84AC-F3B46289FA6D@justatheory.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Jul 10, 2025, at 14:13, David E. Wheeler <david(at)justatheory(dot)com> wrote:

> Oh, is that what’s happening? What needs to happen to properly support pg_upgrade?

Turns out there was an assertion failure that David Johnson spotted in the core dump of the test output and then in the regress log. Turns out I wasn’t using `--enable-assert` in my testing. With that I was able to replicate it and find the core dump in the “Crash Reports” tab of the macOS Console.app with this line:

{"imageOffset":8079100,"sourceLine":1265,"sourceFile":"jsonpath.c","symbol":"jspGetLeftArg","imageIndex":0,"symbolLocation":348},

When I switched to using jspGetLeftArg and jspGetRightArg in the last patch, I forgot to add the assertions you originally had in your patch, Florents. Resolved in the attached, which now passes `make check-world` for me.

Also available as a pull request[1].

Best,

David

[1] https://github.com/theory/postgres/pull/12/files

Attachment Content-Type Size
v10-0001-Rename-jsonpath-method-arg-tokens.patch application/octet-stream 3.9 KB
v10-0002-Add-additional-jsonpath-string-methods.patch application/octet-stream 48.5 KB
unknown_filename text/plain 2 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-07-10 22:45:04 Re: [PING] fallocate() causes btrfs to never compress postgresql files
Previous Message Nathan Bossart 2025-07-10 21:42:23 Re: Horribly slow pg_upgrade performance with many Large Objects