| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Dimitrios Apostolou <jimis(at)gmx(dot)net> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: [PING] fallocate() causes btrfs to never compress postgresql files |
| Date: | 2025-07-10 22:45:04 |
| Message-ID: | CA+hUKGKAS_eWJh_WqHLU3hmMDx7+mJaointh6LMnZrQnR-AeAA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 11, 2025 at 5:39 AM Dimitrios Apostolou <jimis(at)gmx(dot)net> wrote:
> > I applied the patch on PostgreSQL v17 and am testing it now. I chose
> > ftruncate method and I see ftruncate in action using strace while doing
> > pg_restore of a big database. Nothing unexpected has happened so far. I also
> > verified that files are being compressed, obeying Btrfs's mount option
> > compress=zstd.
> >
> > Thanks for the patch! What are the odds of commiting it to v17?
>
> Ping. :-)
> Patch behaves good for me. Any chance of applying it and backporting it?
Yeah, this seems to make sense, as it is a pretty bad regression for
people who are counting on BTRFS compression for their large database.
Not so sure about the threshold bit -- I'd probably leave that out of
the backport in the interest of stable branch-minimalism. Anyone have
any better ideas, better naming, or objections?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2025-07-10 22:58:58 | Re: Can can I make an injection point wait occur no more than once? |
| Previous Message | David E. Wheeler | 2025-07-10 22:40:43 | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |