From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Philip Warner <pjw(at)rhyme(dot)com(dot)au>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug in pg_dump/restore -o |
Date: | 2002-01-18 16:24:02 |
Message-ID: | 6990.1011371042@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Philip Warner wrote:
>> Here's a patch that seems to do the trick. It may seem large, but it is
>> primarily a reorganization of existing code in pg_backup_db.c to make the
>> code a little clearer and to facilitate the swapping around of some loops.
> I hate to say it but I think this is too risky for 7.2.
It does seem a rather large diff ... however, if I understand it right,
what Philip has done here is to hack pg_restore so that it will do the
right thing with an unmodified 7.1 dump file. This is much superior to
hacking pg_dump to change the emitted dump data. Weren't you telling me
that we might need a solution for someone who had already done pg_dump
-o -Ft and then wiped their 7.1 database?
I think we should scrutinize this as carefully as we can, but apply it
if at all possible.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Dwayne Miller | 2002-01-18 16:41:26 | 7.2b5 notes |
Previous Message | Michael Meskes | 2002-01-18 15:54:09 | [Robert.Hufsky@ser.at: autocommit in ecpg] |