Re: Bug in pg_dump/restore -o

Philip Warner wrote:
> At 23:36 17/01/02 -0500, Bruce Momjian wrote:
> >
> >Yes, that was my proposal. I was consindering a case where the load the
> >schema just to populate a fresh database that is to be used by the
> >application. In such cases, setting the oid makes little sense.
> >
>
> Here's a patch that seems to do the trick. It may seem large, but it is
> primarily a reorganization of existing code in pg_backup_db.c to make the
> code a little clearer and to facilitate the swapping around of some loops.
>
> Let me know how you go...

I hate to say it but I think this is too risky for 7.2. We have a
problem that needs fixing, but seeing as it was broken in 7.1.X as well,
and we are just now realizing it, I think the best bet would be to put
in some code to throw an error for invalid combinations of -F and -o and
keep this for 7.3.

I will wait to see what others say.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026