From: | Michael Banck <mbanck(at)gmx(dot)net> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Dead code in ps_status.c |
Date: | 2025-08-26 15:17:28 |
Message-ID: | 68add009.170a0220.16b3ca.d01e@mx.google.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Tue, Aug 26, 2025 at 03:55:30PM +0200, Michael Banck wrote:
> On Thu, Feb 16, 2023 at 04:52:33PM +1300, Thomas Munro wrote:
> > Therefore I think it is safe to drop the PS_USE_PS_STRING and
> > PS_USE_CHANGE_ARGV code branches, remove a bunch of outdated comments
> > and macro tests, and prune the defunct configure/meson probe.
>
> I noticed Postgres no longer updates the process title on the Hurd, this
> is because this was removed along other legacy platforms in this commit
> as it was using PS_USE_PS_STRING.
By the way, on the back branches from 13-15 (before the above commit)
process title changes don't work either, presumably because __hurd__ (as
opposed to __GNU__ and __gnu_hurd__) has not been defined on GNU/Hurd
for ages (or ever?), see
https://github.com/gcc-mirror/gcc/blob/master/gcc/config/gnu.h#L25
So in case this get backpatched, I think it should be changed to
PS_USE_CLOBBER_ARGV there as well.
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Maxim Orlov | 2025-08-26 15:20:53 | Aggregate Function corr does not always return the correct value |
Previous Message | Jacob Champion | 2025-08-26 15:14:59 | Re: Feature request: A method to configure client-side TLS ciphers for streaming replication |