| From: | Michael Banck <mbanck(at)gmx(dot)net> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Dead code in ps_status.c |
| Date: | 2025-08-26 13:55:30 |
| Message-ID: | 68adbcd3.500a0220.8d4c9.9460@mx.google.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Feb 16, 2023 at 04:52:33PM +1300, Thomas Munro wrote:
> Therefore I think it is safe to drop the PS_USE_PS_STRING and
> PS_USE_CHANGE_ARGV code branches, remove a bunch of outdated comments
> and macro tests, and prune the defunct configure/meson probe.
I noticed Postgres no longer updates the process title on the Hurd, this
is because this was removed along other legacy platforms in this commit
as it was using PS_USE_PS_STRING.
Just doing the same as what Linux does (PS_USE_CLOBBER_ARGV) works, so
I've added the __GNU__ definition to it. Process handling on Linux and
the Hurd are different enough that just changing it to __GLIBC__ would
not be advisable IMV.
Patch attached.
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Define-PS_USE_CLOBBER_ARGV-on-GNU-Hurd-to-re-enable-.patch | text/x-diff | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2025-08-26 13:59:54 | Re: Non-reproducible AIO failure |
| Previous Message | Jakub Wartak | 2025-08-26 13:31:53 | Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring |