Re: remove the unneeded header file math.h in binaryheap.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: liujinyang <21043272(at)qq(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: remove the unneeded header file math.h in binaryheap.c
Date: 2026-01-15 15:26:51
Message-ID: 689686.1768490811@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> I looked around to see if there are more unnecessary inclusions of that
> header and found a few candidates. Things still compile and pass tests
> for me, but of course they may fail on other platforms.

Yeah ... my recollection is that some of our inclusions of <math.h>,
and also of <limits.h>, were needed because assorted platforms didn't
follow the C/POSIX standards about which headers should provide which
symbols. Maybe that's all cleaned up now. I'd worry about Solaris
and AIX as being the most likely stragglers.

Another likely source of obsolete <math.h> usages is in the datetime
code, as a leftover from our old floating-point timestamps.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matheus Alcantara 2026-01-15 15:29:28 Re: support ALTER COLUMN SET EXPRESSION over virtual generated column with check constraint
Previous Message Andres Freund 2026-01-15 15:16:13 Re: remove the unneeded header file math.h in binaryheap.c