| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | liujinyang <21043272(at)qq(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: remove the unneeded header file math.h in binaryheap.c |
| Date: | 2026-01-15 13:43:57 |
| Message-ID: | 202601151335.65rrduj65nat@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-Jan-15, Álvaro Herrera wrote:
> On 2026-01-15, liujinyang wrote:
> > Hi Alvora,
> > thanks for your review.
> > So wha't the next should I do for commit it, because this is my first patch.
>
> Nothing. I'll push it soon, no worries.
BTW how did you notice that the include wasn't necessary?
I looked around to see if there are more unnecessary inclusions of that
header and found a few candidates. Things still compile and pass tests
for me, but of course they may fail on other platforms.
https://cirrus-ci.com/build/4766393398198272
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-remove-include-math.h-where-not-needed.patch | text/x-diff | 9.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-01-15 13:47:34 | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Previous Message | David G. Johnston | 2026-01-15 13:29:19 | Re: how to gate experimental features (SQL/PGQ) |