| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH |
| Date: | 2026-08-27 09:59:18 |
| Message-ID: | 6823e088-fee5-4f6b-8f4a-478c8b4a3a67@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 26.08.26 05:08, Andrey Rachitskiy wrote:
> ср, 26 авг. 2026 г. в 05:50, Fujii Masao <masao(dot)fujii(at)gmail(dot)com
> <mailto:masao(dot)fujii(at)gmail(dot)com>>:
>
> The code change looks good to me.
>
> Regarding the test, how about simplifying it by reusing the existing
> event_trigger_report_end() trigger instead of adding a new event
> trigger function just for this case? We could also reuse the property
> graph created earlier in event_trigger.sql. This would keep the added
> test smaller and fit better with the existing tests.
>
> Dear Fujii-san,
>
> Thanks for the review.
> Agreed, it's better this way.
> fix in v2.
committed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-08-27 10:30:27 | Re: to_char() on integer with V format silently wraps on overflow |
| Previous Message | Miłosz Bieniek | 2026-08-27 08:57:22 | Re: to_char() on integer with V format silently wraps on overflow |