| From: | Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH |
| Date: | 2026-08-26 03:08:06 |
| Message-ID: | CAB8bMis4Ub73gkGg+zm1+x0f3aPr=W9ks-aH0KC3ZSVPXV1=Bw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
ср, 26 авг. 2026 г. в 05:50, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>:
> The code change looks good to me.
>
> Regarding the test, how about simplifying it by reusing the existing
> event_trigger_report_end() trigger instead of adding a new event
> trigger function just for this case? We could also reuse the property
> graph created earlier in event_trigger.sql. This would keep the added
> test smaller and fit better with the existing tests.
>
> Dear Fujii-san,
Thanks for the review.
Agreed, it's better this way.
fix in v2.
--
Regards,
Rachitskiy Andrey
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-pg_event_trigger_ddl_commands-for-GRANT-ON-PROPERTY-GRAPH.patch | text/x-patch | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Fujii Masao | 2026-08-26 00:50:24 | Re: BUG #19637: pg_event_trigger_ddl_commands can't process GRANT ON PROPERTY GRAPH |