From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add TAP tests for pg_dump |
Date: | 2016-05-06 19:48:07 |
Message-ID: | 6810.1462564087@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
>> Looks like the test_pg_dump extension made the Windows builds upset.
>> I'm guessing that's because I set 'MODULES_big' even though there isn't
>> a .c component.
>>
>> Doing a local build with that commented out, assuming that works and
>> doesn't generate the .so any more on my Linux box, I'll push the change
>> up to hopefully fix those buildfarm members.
> Alright, apparently that made other Windows buildfarm members unhappy...
> I guess the next approach will be to add back MODULES_big and add in a
> .c file for the Windows systems to be happy about. I'm certainly open
> to other suggestions.
You should not need to do that; cf src/test/modules/test_extensions,
which has got SQL-only extensions.
But at this point I think Peter's complaint has some force to it, and that
what you ought to do is revert the testing patch. You can have another go
after beta1.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2016-05-06 20:07:54 | Re: pgsql: Add TAP tests for pg_dump |
Previous Message | Stephen Frost | 2016-05-06 19:44:02 | Re: pgsql: Add TAP tests for pg_dump |
From | Date | Subject | |
---|---|---|---|
Next Message | Jerry Sievers | 2016-05-06 19:50:36 | Re: Feature request: make cluster_name GUC useful for psql prompts |
Previous Message | Robert Haas | 2016-05-06 19:46:13 | Re: Default Roles |