Re: pgsql: Add TAP tests for pg_dump

* Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > src/test/modules/test_pg_dump/Makefile | 25 +
> > src/test/modules/test_pg_dump/README | 2 +
> > .../modules/test_pg_dump/expected/test_pg_dump.out | 6 +
> > src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 1 +
> > src/test/modules/test_pg_dump/t/001_base.pl | 535 ++++
> > .../modules/test_pg_dump/test_pg_dump--1.0.sql | 15 +
> > src/test/modules/test_pg_dump/test_pg_dump.control | 3 +
>
> Looks like the test_pg_dump extension made the Windows builds upset.
> I'm guessing that's because I set 'MODULES_big' even though there isn't
> a .c component.
>
> Doing a local build with that commented out, assuming that works and
> doesn't generate the .so any more on my Linux box, I'll push the change
> up to hopefully fix those buildfarm members.

Alright, apparently that made other Windows buildfarm members unhappy...

I guess the next approach will be to add back MODULES_big and add in a
.c file for the Windows systems to be happy about. I'm certainly open
to other suggestions.

The intagg contrib modules doesn't have a .c file either, nor a
MODULES_big line, and I don't see any errors with it. I'm not terribly
familiar with how the Windows builds are run though.

Thanks!

Stephen