Re: Re: libpq host/hostaddr/conninfo inconsistencies

From: David Steele <david(at)pgmasters(dot)net>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Re: libpq host/hostaddr/conninfo inconsistencies
Date: 2019-03-21 17:54:55
Message-ID: 676b5e49-b0cf-f458-825a-a5cff013029e@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/22/19 9:44 PM, Fabien COELHO wrote:
>
> Hmmm, I do not buy the typing argument: "host" is actually for
> everything, including directories. I do not think that adding "hostdir"
> would be desirable.
>
>> In any case, the existing doco never comes out and states either
>> rule set in so many words.  Maybe it should.

Personally I like the second and third edit from Robert's patch, but not
the first one. I'm having a hard time seeing why you would specify host
*and* hostaddr as this seems to imply.

I also agree with Fabien's comment that host can be a path -- it's
really a path to a socket file, but it's certainly not a host name or IP
address. Perhaps that should be called out explicitly.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2019-03-21 18:01:15 Re: Re: [proposal] Add an option for returning SQLSTATE in psql error message
Previous Message Marius Timmer 2019-03-21 17:46:32 Re: [HACKERS] Can ICU be used for a database's default sort order?