Re: Re: [proposal] Add an option for returning SQLSTATE in psql error message

From: David Steele <david(at)pgmasters(dot)net>
To: didier <did447(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stěhule <pavel(dot)stehule(at)gmail(dot)com>, andrew(at)tao11(dot)riddles(dot)org(dot)uk, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [proposal] Add an option for returning SQLSTATE in psql error message
Date: 2019-03-21 18:01:15
Message-ID: aa2e269f-aff4-97da-8a65-b4f6ffe2790a@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/4/19 5:54 AM, Michael Paquier wrote:
> On Mon, Jan 07, 2019 at 10:44:24PM +0100, didier wrote:
>> On Sat, Jan 5, 2019 at 6:30 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>>>> Why are you not including a test for \set VERBOSITY verbose?
>>>
>>> Stability of the output would be a problem ...
>>>
>>> Yes it could moreover the functionality wasn't tested before.
>> Should I add one ?
>
> Unpredictible outputs mean more maintenance and more alternate
> outputs. I have moved the patch to next CF, still ready for
> committer.

What do you think, Peter? Is the extra test valuable or will it cause
unpredictable outputs as Tom and Michael predict?

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2019-03-21 18:06:36 Re: Re: INSTALL file
Previous Message David Steele 2019-03-21 17:54:55 Re: Re: libpq host/hostaddr/conninfo inconsistencies