| From: | Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIP: About CMake v2 |
| Date: | 2016-11-10 19:32:27 |
| Message-ID: | 674d4819-4453-b01a-aa7f-13215b561708@catalyst.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/11/16 08:15, Yury Zhuravlev wrote:
> Craig Ringer wrote:
>> So personally I think it'd be fine if a cmake build defaulted to
>> finding and using what it could, but offered a --minimal mode or
>> whatever that gets us just core postgres + whatever we enable
>> explicitly. But our current behaviour is OK too.
>
> To me it's best way. But I'm not sure what Tom Lane will accept this.
>
>
I just had a play with this patch - nice! (ok so it needs a fix so that
the compile completes as mentioned prev).
I would recommend making it behave as Tom suggested. *Then* add an
--autodetect or similar option that makes
behave in the 'finding and using what it could' manner as a 2nd patch.
regards
Mark
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-10 19:40:08 | Re: WIP: About CMake v2 |
| Previous Message | Tom Lane | 2016-11-10 19:15:09 | Re: Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed. |