| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Subject: | Re: Offline enabling/disabling of data checksums |
| Date: | 2019-03-12 10:06:55 |
| Message-ID: | 6744541552385215@iva8-3af116a85b74.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
> Not doing the check is a bad idea as ControlFileData should be compatible
> between the binary and the data read. I am attaching a fresh 0001
> which should be back-patched down to v11 as a bug fix.
Looks fine. We need add few words to documentation?
>>> if (badblocks > 0)
>>> return 1;
>>
>> Small question: why return 1 instead of exit(1)?
>
> OK, let's fix that on the way as part of the renaming.
Was not changed?..
I have no new notes after reading updated patchset.
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2019-03-12 10:13:46 | Re: Offline enabling/disabling of data checksums |
| Previous Message | Michael Paquier | 2019-03-12 09:23:01 | Re: pg_rewind : feature to rewind promoted standby is broken! |