Re: [PATCH] Improve geometric types

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: emre(at)hasegeli(dot)com, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: [PATCH] Improve geometric types
Date: 2018-07-26 15:12:50
Message-ID: 672f4c42-6742-c1ec-e9a4-1994b815acc7@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 07/11/2018 07:13 PM, Emre Hasegeli wrote:
> New versions are attached after the <float.h> patch got in. I noticed
> tests failing on Windows [1] and added alternative .out file.
>
> [1] https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.5235
>

The version posted about two weeks ago is slightly broken - AFAICS the
float.h includes in geo_ops.c and gistproc.c need to be part of 0002,
not 0003. Attached is a version fixing that.

Barring objections, I'll get this committed over the next few days, once
I review all the individual parts once more. I'm planning to commit the
6 parts separately, as submitted. No backpatching, as discussed before.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Refactor-geometric-functions-and-operators-code.patch text/x-patch 82.8 KB
0002-Provide-header-file-for-built-in-float-datatypes.patch text/x-patch 59.3 KB
0006-Improve-test-coverage-of-geometric-types.patch text/x-patch 645.9 KB
0005-Check-for-float-0-after-multiplications-and-division.patch text/x-patch 2.8 KB
0004-Fix-obvious-problems-around-the-line-datatype.patch text/x-patch 9.4 KB
0003-Use-the-built-in-float-datatype-to-implement-geometr.patch text/x-patch 54.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2018-07-26 15:40:07 Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack
Previous Message Dmitry Dolgov 2018-07-26 15:07:32 Re: [HACKERS] advanced partition matching algorithm for partition-wise join