Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Schneider, Jeremy" <schnjere(at)amazon(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "Albin, Lloyd P" <lalbin(at)scharp(dot)org>
Subject: Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack
Date: 2018-07-26 15:40:07
Message-ID: 082C3D70-C39D-41F4-B889-C128D09DE02E@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 7/26/18, 10:07 AM, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote:
> The first time we use this callback, the relation won't be locked, so
> isn't it possible that we won't get a valid tuple here? I did notice
> that callbacks like RangeVarCallbackForRenameRule,
> RangeVarCallbackForPolicy, and RangeVarCallbackForRenameTrigger assume
> that the relation can be concurrently dropped, but
> RangeVarCallbackOwnsRelation does not. Instead, we assume that the
> syscache search will succeed if the given OID is valid. Is this a
> bug, or am I missing something?

Please pardon the noise. I see that we don't accept invalidation
messages until later on in RangeVarGetRelidExtended(), at which point
we'll retry and get InvalidOid for concurrently dropped relations.

Nathan

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2018-07-26 16:38:43 BUG #15299: relation does not exist errors
Previous Message Bossart, Nathan 2018-07-26 15:06:59 Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-07-26 16:19:34 Re: Speeding up INSERTs and UPDATEs to partitioned tables
Previous Message Tomas Vondra 2018-07-26 15:12:50 Re: [PATCH] Improve geometric types