Re: [PATCH] Improve geometric types

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: tomas(dot)vondra(at)2ndquadrant(dot)com
Cc: emre(at)hasegeli(dot)com, thomas(dot)munro(at)enterprisedb(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Improve geometric types
Date: 2018-07-27 08:20:21
Message-ID: 20180727.172021.167444673.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for taking this.

At Thu, 26 Jul 2018 17:12:50 +0200, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote in <672f4c42-6742-c1ec-e9a4-1994b815acc7(at)2ndquadrant(dot)com>
> On 07/11/2018 07:13 PM, Emre Hasegeli wrote:
> > New versions are attached after the <float.h> patch got in. I noticed
> > tests failing on Windows [1] and added alternative .out file.
> > [1]
> > https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.5235
> >
>
> The version posted about two weeks ago is slightly broken - AFAICS the
> float.h includes in geo_ops.c and gistproc.c need to be part of 0002,
> not 0003. Attached is a version fixing that.
>
> Barring objections, I'll get this committed over the next few days,
> once I review all the individual parts once more. I'm planning to
> commit the 6 parts separately, as submitted. No backpatching, as
> discussed before.

+1 for no backpatching, and not merging into single big patch.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2018-07-27 08:27:26 RE: Temporary tables prevent autovacuum, leading to XID wraparound
Previous Message David Fetter 2018-07-27 08:10:58 Re: Early WIP/PoC for inlining CTEs