Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column

> On May 7, 2026, at 12:34, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
>> On May 7, 2026, at 01:13, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> wrote:
>>
>> On Wed, May 6, 2026 at 4:39 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>>
>>> On 05.05.26 23:50, Paul A Jungwirth wrote:
>>>> On Wed, Apr 22, 2026 at 11:03 AM Paul A Jungwirth
>>>> <pj(at)illuminatedcomputing(dot)com> wrote:
>>>>>
>>>>> Good catch! I removed that line in v7 (attached). I also included your
>>>>> test change to compute the range len by hand. Also a rebase was
>>>>> necessary after d3bba04154.
>>>>
>>>> This needed a rebase. v8 attached.
>>>
>>> This patch fails the injection_points/isolation test for me. It looks
>>> like it causes a server crash. Check please.
>>
>> Sorry, I didn't have injection_points enabled, but now I see it too.
>> The attached v9 fixes it.
>>
>> Yours,
>>
>> --
>> Paul ~{:-)
>> pj(at)illuminatedcomputing(dot)com
>> <v9-0001-Fix-some-problems-with-UPDATE-FOR-PORTION-OF.patch>
>
> Hi Paul,
>
> I didn’t review this patch earlier because, from the subject, I thought it was only about recomputing generated stored columns. I just noticed that the patch also changes the inheritance-table path, and I posted another patch for the inheritance-table bug. Please see [1].
>
> I tried applying the new tests from my patch on top of this patch, and it looks like this patch still does not fix the multi-inheritance case.
>
> So I’d like to check with you how we should proceed. I think there are two options:
>
> 1. Keep this patch focused on the generated-column issue described in the subject, and use my patch to fix the inheritance-table bug.
> 2. I can continue from this patch and extend it to fix the multi-inheritance case as well.
>
> Please let me know what you prefer.
>
> [1] https://www.postgresql.org/message-id/4245F94D-84F1-4E05-BF81-C458A6CF9901%40gmail.com
>

I just looked into v9 and made a fix in ExecInitForPortionOf() that resolves the bug with multi-inheritance tables. I also added a test case for that.

The inheritance-table bug affects not only UPDATE, but also DELETE, so I added test cases for DELETE as well. Please see 0002 for my changes.

To make each commit self-contained, would you mind moving the code for the inheritance-table fix to 0002? Then you can keep focusing on 0001, and I can continue working on 0002.

PFA v10 - 0001 the same as v9. 0002 fixed a bug with multi-inheritance tables.

(Note, in 0002, there is a comment format change around line 1496, that was done by pgindent.)

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/