| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column |
| Date: | 2026-05-07 04:34:43 |
| Message-ID: | 27BD5D23-19C9-4FD1-8935-9C788C3C9869@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On May 7, 2026, at 01:13, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> wrote:
>
> On Wed, May 6, 2026 at 4:39 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> On 05.05.26 23:50, Paul A Jungwirth wrote:
>>> On Wed, Apr 22, 2026 at 11:03 AM Paul A Jungwirth
>>> <pj(at)illuminatedcomputing(dot)com> wrote:
>>>>
>>>> Good catch! I removed that line in v7 (attached). I also included your
>>>> test change to compute the range len by hand. Also a rebase was
>>>> necessary after d3bba04154.
>>>
>>> This needed a rebase. v8 attached.
>>
>> This patch fails the injection_points/isolation test for me. It looks
>> like it causes a server crash. Check please.
>
> Sorry, I didn't have injection_points enabled, but now I see it too.
> The attached v9 fixes it.
>
> Yours,
>
> --
> Paul ~{:-)
> pj(at)illuminatedcomputing(dot)com
> <v9-0001-Fix-some-problems-with-UPDATE-FOR-PORTION-OF.patch>
Hi Paul,
I didn’t review this patch earlier because, from the subject, I thought it was only about recomputing generated stored columns. I just noticed that the patch also changes the inheritance-table path, and I posted another patch for the inheritance-table bug. Please see [1].
I tried applying the new tests from my patch on top of this patch, and it looks like this patch still does not fix the multi-inheritance case.
So I’d like to check with you how we should proceed. I think there are two options:
1. Keep this patch focused on the generated-column issue described in the subject, and use my patch to fix the inheritance-table bug.
2. I can continue from this patch and extend it to fix the multi-inheritance case as well.
Please let me know what you prefer.
[1] https://www.postgresql.org/message-id/4245F94D-84F1-4E05-BF81-C458A6CF9901%40gmail.com
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2026-05-07 05:05:46 | Re: Support EXCEPT for ALL SEQUENCES publications |
| Previous Message | shveta malik | 2026-05-07 04:31:37 | Re: Proposal: Conflict log history table for Logical Replication |