| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pramsey(at)cleverelephant(dot)ca, ojford(at)gmail(dot)com, peter(at)eisentraut(dot)org, krasiyan(at)gmail(dot)com, vik(at)postgresfriends(dot)org, andrew(at)tao11(dot)riddles(dot)org(dot)uk, david(at)fetter(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |
| Date: | 2025-10-11 05:57:58 |
| Message-ID: | 66A28678-BDC0-4266-9244-74320D578222@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 11, 2025, at 13:42, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>
>>> Also the error is certainly user-facing,
>>> so using elog() was quite inappropriate. It should be ereport with an
>>> errcode of (probably) ERRCODE_FEATURE_NOT_SUPPORTED. Rolling your
>>> own implementation of get_func_name() wasn't great either.
>>
>> I overlooked the elog() call and "own implementation of
>> get_func_name()". Will fix.
>
> Attached is a trivial patch to fix that. I am going to push it if
> there's no objection.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
> <v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch>
I just take a quick look at the patch, a tiny comment is:
```
+ char *funcname = get_func_name(fcinfo->flinfo->fn_oid);
```
This can be a “const char *”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-10-11 06:04:29 | Re: [PATCH TEST] Fix logical replication setup in subscription test `t/009_matviews.pl` |
| Previous Message | Chao Li | 2025-10-11 05:53:59 | Re: new environment variable INITDB_LOCALE_PROVIDER |