Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: pramsey(at)cleverelephant(dot)ca, ojford(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, krasiyan(at)gmail(dot)com, vik(at)postgresfriends(dot)org, andrew(at)tao11(dot)riddles(dot)org(dot)uk, david(at)fetter(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date: 2025-10-11 05:42:18
Message-ID: 20251011.144218.1729318385118014326.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> Also the error is certainly user-facing,
>> so using elog() was quite inappropriate. It should be ereport with an
>> errcode of (probably) ERRCODE_FEATURE_NOT_SUPPORTED. Rolling your
>> own implementation of get_func_name() wasn't great either.
>
> I overlooked the elog() call and "own implementation of
> get_func_name()". Will fix.

Attached is a trivial patch to fix that. I am going to push it if
there's no objection.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Attachment Content-Type Size
v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-10-11 05:53:59 Re: new environment variable INITDB_LOCALE_PROVIDER
Previous Message Chao Li 2025-10-11 05:24:24 Re: Fix array access (src/bin/pg_dump/pg_dump.c)