| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Serge Negodyuck <petr(at)petrovich(dot)kiev(dot)ua>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #8673: Could not open file "pg_multixact/members/xxxx" on slave during hot_standby |
| Date: | 2014-06-06 17:04:29 |
| Message-ID: | 6687.1402074269@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> After some simplification I think it should be clearer. Thanks Andres
> for commenting offlist.
I find this not only unreadable but a bit scary:
! if (offset + MAX_MEMBERS_IN_LAST_MEMBERS_PAGE < offset)
I'm worried whether some compilers might not decide that that's a
can't-happen situation, and optimize the test away entirely. I think
Andres' proposal is probably safer (though it needs comments).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-06-06 17:16:56 | Re: BUG #8673: Could not open file "pg_multixact/members/xxxx" on slave during hot_standby |
| Previous Message | Alvaro Herrera | 2014-06-06 16:47:27 | Re: BUG #8673: Could not open file "pg_multixact/members/xxxx" on slave during hot_standby |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2014-06-06 17:14:09 | Re: pg_receivexlog add synchronous mode |
| Previous Message | Alvaro Herrera | 2014-06-06 16:47:27 | Re: BUG #8673: Could not open file "pg_multixact/members/xxxx" on slave during hot_standby |