| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve pgindent's formatting named fields in struct literals and varidic functions |
| Date: | 2026-05-05 18:10:10 |
| Message-ID: | 664781.1778004610@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andreas Karlsson <andreas(at)proxel(dot)se> writes:
> Rebased patch on top of HEAD.
I've reviewed and tested this, and attached is the version I have
staged for commit. Differences from yours:
* Bump pg_bsd_indent's version number to ensure people use the
right version.
* Include the change in tests/declarations.0.stdout in the main
patch. Without this, "make check-world" fails after that patch.
We don't want to create land-mines like that for future git
bisect runs.
v6-0002 shows the effects the patch would currently have.
This isn't a commit, since the effects could very well still
change before this gets committed.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Make-pg_bsd_indent-add-a-space-between-comma-and-.patch | text/x-diff | 3.6 KB |
| v6-0002-effects.patch.nocfbot | text/x-diff | 63.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2026-05-05 18:14:53 | Re: Improve pgindent's formatting named fields in struct literals and varidic functions |
| Previous Message | Nathan Bossart | 2026-05-05 17:57:10 | Re: small cleanup for s_lock.h |