Re: Improve pgindent's formatting named fields in struct literals and varidic functions

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve pgindent's formatting named fields in struct literals and varidic functions
Date: 2026-04-12 21:06:24
Message-ID: 71e9889c-86be-4084-a5ae-fc535221b5fb@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/31/26 8:57 PM, Andreas Karlsson wrote:
> On 3/31/26 8:13 PM, Tom Lane wrote:
>> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
>>> I think the best time to get it in is a few weeks after the feature
>>> freeze.  That way we minimize the impact on any fixes during the
>>> stabilization period.  I'm not sure at what point relative to the betas
>>> though; is it better to do it before, so that we have a chance to fix
>>> any possible problems before they hit users, or is it better to do after
>>> beta1, so that patches that we discover need reverting for pg19 have
>>> already had a chance to be so?
>>
>> [...]
>>
>> So we haven't been totally consistent about it, but mid-May (a couple
>> weeks before making the new branch) seems like the usual choice.
> Makes sense to merge it while the tree is less noisy. Especially right
> now might be the most annoying time possible.
Rebased patch on top of HEAD.

Andreas

Attachment Content-Type Size
v5-0001-Make-pgindent-add-a-space-between-comma-and-perio.patch text/x-patch 1.9 KB
v5-0002-Run-pgindent-add-a-space-between-comma-and-period.patch text/x-patch 69.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2026-04-12 22:27:33 Re: Change default of jit to off
Previous Message Tom Lane 2026-04-12 20:24:42 Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?