Re: pgsql: Fix pg_basebackup with in-place tablespaces.

From: David Steele <david(at)pgmasters(dot)net>
To: Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces.
Date: 2022-03-15 20:40:35
Message-ID: 66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 3/14/22 19:31, Thomas Munro wrote:
> Fix pg_basebackup with in-place tablespaces.
>
> Previously, pg_basebackup from a cluster that contained an 'in-place'
> tablespace, as introduced by commit 7170f215, would produce a harmless
> warning on Unix and fail completely on Windows.

Perhaps I'm being picky, but seems like this logic should be wrapped in:

if (allow_in_place_tablespaces)
{
<...>
}

I worry about strange effects when this GUC is not enabled.

Regards,
-David

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-03-15 21:28:23 Re: pgsql: Fix pg_basebackup with in-place tablespaces.
Previous Message Andres Freund 2022-03-15 19:04:28 Re: pgsql: Add 'basebackup_to_shell' contrib module.