Re: pgsql: Add 'basebackup_to_shell' contrib module.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: 2022-03-15 19:04:28
Message-ID: 20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2022-03-15 17:33:12 +0000, Robert Haas wrote:
> Add 'basebackup_to_shell' contrib module.
>
> As a demonstration of the sort of thing that can be done by adding a
> custom backup target, this defines a 'shell' target which executes a
> command defined by the system administrator. The command is executed
> once for each tar archive generate by the backup and once for the
> backup manifest, if any. Each time the command is executed, it
> receives the contents of th file for which it is executed via standard
> input.
>
> The configured command can use %f to refer to the name of the archive
> (e.g. base.tar, $TABLESPACE_OID.tar, backup_manifest) and %d to refer
> to the target detail (pg_basebackup --target shell:DETAIL). A target
> detail is required if %d appears in the configured command and
> forbidden if it does not.
>
> Patch by me, reviewed by Abhijit Menon-Sen.

> Modified Files
> --------------
> contrib/Makefile | 1 +
> contrib/basebackup_to_shell/Makefile | 19 +
> contrib/basebackup_to_shell/basebackup_to_shell.c | 419 ++++++++++++++++++++++
> doc/src/sgml/basebackup-to-shell.sgml | 69 ++++
> doc/src/sgml/contrib.sgml | 1 +
> doc/src/sgml/filelist.sgml | 1 +
> 6 files changed, 510 insertions(+)

Seems like this ought to have at least some basic test to make sure it
actually works / keeps working?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Steele 2022-03-15 20:40:35 Re: pgsql: Fix pg_basebackup with in-place tablespaces.
Previous Message Andres Freund 2022-03-15 18:28:58 Re: pgsql: Track LLVM 15 changes.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-03-15 19:27:05 Re: pg14 psql broke \d datname.nspname.relname
Previous Message Jacob Champion 2022-03-15 17:59:08 Re: Kerberos delegation support in libpq and postgres_fdw