Re: error in compilation!

From: "Gurjeet Singh" <singh(dot)gurjeet(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PGSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: error in compilation!
Date: 2006-05-27 19:35:08
Message-ID: 65937bea0605271235i4ae5e3cau1dcb8697da68acde@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Any ideas how I can revert back to compilable code?

On 5/28/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I am thinking it is best to always use E'' in that case. OK?
>
> I'm planning to revert it to the previous logic: E if there's any
> backslash. I think we have to do likewise in quote_literal() for
> much the same reason: insufficient confidence that we know how
> the result will be used. (Note dblink uses quote_literal for
> strings it will send to the other database.)
>
> Currently looking through the rest of the patch. I'm wondering
> about appendStringLiteral: maybe we should kill that entirely
> in favor of using PQescapeStringConn? It's not nearly bright
> enough about encoding for instance (and it *will* be used in
> client-only encodings).
>
> regards, tom lane
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-05-27 20:02:46 Better to dump tabs as tabs, or \t?
Previous Message Tom Lane 2006-05-27 19:18:04 Re: error in compilation!