| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: Sub-millisecond [autovacuum_]vacuum_cost_delay broken |
| Date: | 2023-03-09 23:17:59 |
| Message-ID: | 658998.1678403879@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Melanie Plageman <melanieplageman(at)gmail(dot)com> writes:
> On Thu, Mar 9, 2023 at 5:27 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> A minimalistic fix could be as attached. I'm not sure if it's worth
>> making the state variable global so that it can be reset to zero in
>> the places where we zero out VacuumCostBalance etc. Also note that
>> this is ignoring the VacuumSharedCostBalance stuff, so you'd possibly
>> have the extra delay accumulating in unexpected places when there are
>> multiple workers. But I really doubt it's worth worrying about that.
> What if someone resets the delay guc and there is still a large residual?
By definition, the residual is less than 1msec.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-03-09 23:31:10 | Re: buildfarm + meson |
| Previous Message | Juan José Santamaría Flecha | 2023-03-09 23:12:37 | Re: pg_dump/pg_restore: Fix stdin/stdout handling of custom format on Win32 |