Re: TAP output format in pg_regress

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: TAP output format in pg_regress
Date: 2022-11-28 19:27:02
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 28 Nov 2022, at 20:02, Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:

> From my reviewer's point of view patch is ready for commit.
> Thank you for your patience :-)

Thanks for review.

The attached tweaks a few comments and attempts to address the compiler warning
error in the CFBot CI. Not sure I entirely agree with the compiler there but
here is an attempt to work around it at least (by always copying the va_list
for the logfile). It also adds a missing va_end for the logfile va_list.

I hope this is close to a final version of this patch (commitmessage needs a
bit of work though).

> PS Should I change commitfest status?

Sure, go ahead.

Daniel Gustafsson

Attachment Content-Type Size
v14-0001-Change-pg_regress-output-format-to-be-TAP-compli.patch application/octet-stream 35.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2022-11-28 19:34:10 Re: fixing CREATEROLE
Previous Message Robert Haas 2022-11-28 19:11:40 Re: Collation version tracking for macOS