Re: TAP output format in pg_regress

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: TAP output format in pg_regress
Date: 2022-11-28 19:02:38
Message-ID: 5348601.u5redSiXY4@thinkpad-pgpro
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

В письме от понедельник, 28 ноября 2022 г. 21:28:48 MSK пользователь Andres
Freund написал:
> On 2022-11-28 14:13:16 +0100, Daniel Gustafsson wrote:
> > > On 27 Nov 2022, at 11:22, Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
> > > В письме от суббота, 26 ноября 2022 г. 23:35:45 MSK пользователь Daniel
> > > Gustafsson написал:
> > >
> > > I wold suggest to use word immediate instead of noatexit. This will do
> > > the
> > > code much more sensible for me.
> >
> > I think noatexit is clearer since the codepath is specifically to avoid
> > any
> > registered atexit functions. The point of this function is to be able to
> > call bail while in a function registered with atexit() so I think the
> > current name is better.
> +1

Ok, then I would not insist on it.

> > So this extra offset indicates that test is being included into parallel
> > group? Guess it not really obvious...
> Grouping parallel tests via an initial list of test and then indenting each
> test with whitespace was committed 22 years ago. While there might be
> better
> ways to do this, the lack of complaints so far at least seems to indicate
> that it isn't all too terrible.

Ok, it was there for 22 years, it will do no harm if it is left this way for
some time :-)


From my reviewer's point of view patch is ready for commit.

Thank you for your patience :-)

PS Should I change commitfest status?

Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM:

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-11-28 19:11:40 Re: Collation version tracking for macOS
Previous Message Andres Freund 2022-11-28 18:59:09 Re: Add tracking of backend memory allocated to pg_stat_activity