On 24.09.26 17:43, Nazir Bilal Yavuz wrote:
> On Thu, 24 Sept 2026 at 17:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>>> A subproblem is that if pgindent fails on many files, it doesn't clean
>>> up after itself but leaves many pgsrc*.BAK files lying around. The
>>> first patch fixes that.
>>
>> I object to this patch. src/tools/pgindent/README documents that
>> the presence of those files is useful for detecting where pgindent
>> failed. Without them there's not an easy signal.
>
> I remember being frustrated with too many pgsrc*.BAK files but that
> was when pgindent processed the build folder. I think we might not
> need 0001 after 0003.
Here is an updated patch that just implements automatic skipping of
build directories. It's quite compact and seems universally useful.