Re: pgindent to ignore build directories

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent to ignore build directories
Date: 2026-09-24 15:43:43
Message-ID: CAN55FZ2b-0YZv0d5iqMt1PdXY3m9=zTq7KeGVscRpXOfDncTig@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, 24 Sept 2026 at 17:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> > A subproblem is that if pgindent fails on many files, it doesn't clean
> > up after itself but leaves many pgsrc*.BAK files lying around. The
> > first patch fixes that.
>
> I object to this patch. src/tools/pgindent/README documents that
> the presence of those files is useful for detecting where pgindent
> failed. Without them there's not an easy signal.

I remember being frustrated with too many pgsrc*.BAK files but that
was when pgindent processed the build folder. I think we might not
need 0001 after 0003.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Trakshan Mishra 2026-09-24 15:44:59 merge-delete isolation test fails since 85f55534e80
Previous Message Ashutosh Bapat 2026-09-24 15:43:34 Re: [PATCH] Two remaining shmem attachment issues in single-user mode