Re: Adding CI to our tree

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Adding CI to our tree
Date: 2022-01-13 20:27:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 1/13/22 13:55, Andres Freund wrote:
>> It needs to avoid running on the buildfarm, right ?
> I guess so. It currently appears to have its own logic for finding contrib
> (and other) tap tests:
> foreach my $testdir (glob("$pgsql/contrib/*"))
> {
> next unless -d "$testdir/t";
> my $testname = basename($testdir);
> next unless step_wanted("contrib-$testname");
> print time_str(), "running contrib test $testname ...\n" if $verbose;
> run_tap_test("$testdir", "contrib-$testname", undef);
> }
> but does run vcregress contribcheck, modulescheck.
> Andrew, do you see a better way than what Justin is proposing here?

I can probably adjust to whatever we decide to do. But I think we're
really just tinkering at the edges here. What I think we really need is
the moral equivalent of `make check-world` in one invocation of

While we're on the subject of, there's this recent
discussion, which is on my list of things to return to:



Andrew Dunstan

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniil Zakhlystov 2022-01-13 21:12:17 Re: libpq compression (part 2)
Previous Message Robert Haas 2022-01-13 20:26:56 Re: Patch: Code comments: why some text-handling functions are leakproof