From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
Subject: | Re: pg_upgrade fails to detect unsupported arrays and ranges |
Date: | 2019-11-10 22:39:14 |
Message-ID: | 63DE9A1C-5F59-47AF-90C9-26A7EF9897B3@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 10 Nov 2019, at 22:12, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 10 Nov 2019, at 20:07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> (Note: this patch is shown with --ignore-space-change
>>> to make it more reviewable, but I did re-pgindent the code.) Then
>>> 0002 actually adds the array and range cases.
>
>> Was the source pgindented, but not committed, before generating the patches? I
>> fail to apply them on master (or REL_12_STABLE) on what seems to be only
>> whitespace changes.
>
> Hm, I suppose it might be hard to apply the combination of the patches
> (maybe something involving patch -l would work). For simplicity, here's
> the complete patch for HEAD. I fixed a missing schema qualification.
Applies, builds clean and passes light testing. I can see the appeal of
including it before the wrap, even though I personally would've held off.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-11-10 23:06:17 | Re: pg_upgrade fails to detect unsupported arrays and ranges |
Previous Message | Daniel Gustafsson | 2019-11-10 22:26:09 | Re: pg_upgrade fails to detect unsupported arrays and ranges |