| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Subject: | Re: pg_upgrade fails to detect unsupported arrays and ranges |
| Date: | 2019-11-10 21:12:38 |
| Message-ID: | 4978.1573420358@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 10 Nov 2019, at 20:07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> (Note: this patch is shown with --ignore-space-change
>> to make it more reviewable, but I did re-pgindent the code.) Then
>> 0002 actually adds the array and range cases.
> Was the source pgindented, but not committed, before generating the patches? I
> fail to apply them on master (or REL_12_STABLE) on what seems to be only
> whitespace changes.
Hm, I suppose it might be hard to apply the combination of the patches
(maybe something involving patch -l would work). For simplicity, here's
the complete patch for HEAD. I fixed a missing schema qualification.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| fix-pg_upgrade-unsupported-type-search-2.patch | text/x-diff | 14.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-11-10 21:18:32 | Re: Index Skip Scan |
| Previous Message | Tom Lane | 2019-11-10 21:05:43 | Re: pg_upgrade fails to detect unsupported arrays and ranges |