| From: | "Joel Jacobson" <joel(at)compiler(dot)org> |
|---|---|
| To: | "Sho Ito" <i(dot)sho(dot)0628(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix leaked hash scans in pg_listening_channels() |
| Date: | 2026-10-21 18:56:31 |
| Message-ID: | 6393980f-3e62-4e08-b7b8-4b80163b6738@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 21, 2026, at 09:19, Sho Ito wrote:
> On Mon, Oct 19, 2026 at 2:42 PM Joel Jacobson <joel(at)compiler(dot)org> wrote:
>> Attached patch uses InitMaterializedSRF() to complete the scan
>> before returning rows, following 257c8231bf.
>
> Hi Joel,
>
> I reviewed the attached patch on master with assertions enabled. Before the fix,
> repeated target-list calls under `LIMIT` in one transaction cause
> a backend crash with `PANIC: ERRORDATA_STACK_SIZE exceeded`. With the patch,
> the same workload completes without warnings or errors.
>
> The materialization approach follows the SRF guidance in `funcapi.h`
> and looks good to me.
Thanks for review.
Here is the commitfest entry:
https://commitfest.postgresql.org/patch/7481/
If you think it's Ready for Committer
you can update the status there.
>
> Thanks,
> Sho
>
> --
> =======================================
> *Sho Ito (Sean)*
>
> E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
> LinkedIn: _https://www.linkedin.com/in/sho-ito-0628/_
> GitHub: https://github.com/sean0628/
> =======================================
--
Kind regards,
Joel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-10-21 19:15:00 | Re: Introduce XID age based replication slot invalidation |
| Previous Message | Nitin Motiani | 2026-10-21 18:36:44 | [PATCH v1] Fix for bug #19773 : pg_dump differing generation expressions of inherited columns |