Re: Getting rid of aggregate_dummy()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Getting rid of aggregate_dummy()
Date: 2020-11-02 14:22:36
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On 01/11/2020 22:47, Tom Lane wrote:
>> With that, we don't actually need aggregate_dummy() to exist at
>> all, because it's never referenced. Having "aggregate_dummy"
>> as the prosrc value for an aggregate function is now just a
>> random convention; any other string would do as well. (We could
>> save a few bytes in pg_proc by choosing a shorter string, but
>> probably it's better to stick to the existing convention.)

> NULL would seem like the natural value for that.

I wouldn't be in favor of that unless we changed the prolang value
as well. Which could certainly be considered, but it makes the
patch rather more invasive, and I'm not sure it's worth it.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Georgios Kokolatos 2020-11-02 14:43:32 Re: Strange behavior with polygon and NaN
Previous Message Tom Lane 2020-11-02 14:21:16 Re: Getting rid of aggregate_dummy()